Closed
Conversation
Signed-off-by: Ben Sherman <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| } | ||
| } | ||
| else if( (varX=isVariableX(stm.expression)) && (varX.name=='stdin' || varX.name=='stdout') && NF.isDsl2() ) { | ||
| else if( (varX=isVariableX(stm.expression)) && (varX.name=='stdin' || varX.name=='stdout') ) { |
There was a problem hiding this comment.
AssignmentInConditional: Assignment used as conditional value, which always results in true. Use the == operator instead
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Member
A nice error, I hope? 😬 |
Member
Author
|
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
2c461f8 to
23432f3
Compare
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
e2b4a93 to
f32ea0b
Compare
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
cefb067 to
e523afd
Compare
Member
This was referenced Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the following:
I tried to keep the core pieces of the DSL version checker, in case we need it in the future. So the
-dsl1and-dsl2command line args and thenextflow.enable.dslscript variables are still accepted for backwards compatibility, but they are ignored, and trying to enable DSL1 will cause an error.Lots of tests are failing, so I still need to go through them, but I wanted to go ahead and show what all I plan to remove. In general, it looks like a lot of unit tests depend on DSL1 or otherwise deprecated functionality, so hopefully this PR when it's ready will make our test suite much more robust.