fix: use provided appName of NcContent if possible#8157
Merged
Conversation
We already pass `appName` to `NcContent` and we provide this value. So we should make use of this whenever possible. Reason here is if e.g. library is used without the `appName` replacement, or if the app has multiple "sub-apps". One example here is Nextcloud core which has one global `appName` but multiple real app names (e.g. `files`, `files_sharing` etc). Signed-off-by: Ferdinand Thiessen <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8157 +/- ##
==========================================
+ Coverage 52.77% 52.82% +0.04%
==========================================
Files 103 103
Lines 3348 3351 +3
Branches 977 977
==========================================
+ Hits 1767 1770 +3
Misses 1333 1333
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
approved these changes
Feb 3, 2026
Antreesy
approved these changes
Feb 3, 2026
Contributor
Author
|
/backport to stable8 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
We already pass
appNametoNcContentand we provide this value. So we should make use of this whenever possible.Reason here is if e.g. library is used without the
appNamereplacement, or if the app has multiple "sub-apps". One example here is Nextcloud core which has one globalappNamebut multiple real app names (e.g.files,files_sharingetc).🏁 Checklist
stable8for maintained Vue 2 version or not applicable