feat(NcSelectUsers): export NcSelectUsersModel type#8130
Merged
Conversation
Contributor
Author
|
/backport to stable8 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8130 +/- ##
=======================================
Coverage 52.77% 52.77%
=======================================
Files 103 103
Lines 3348 3348
Branches 976 977 +1
=======================================
Hits 1767 1767
Misses 1333 1333
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
added
enhancement
ShGKme
changed the title
IUserData typeIUserData type
Contributor
|
Renamed to be a feature (it adds public API, reverting it is a breaking change). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
fix/user-select-type
branch
from
b80940b to
5e197ad
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
reviewed
Feb 3, 2026
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/user-select-type
branch
from
5e197ad to
fa5fe4e
Compare
ShGKme
approved these changes
Feb 3, 2026
susnux
changed the title
IUserData typeNcSelectUsersModel type
Antreesy
approved these changes
Feb 3, 2026
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
So that you can make use of the type inside apps, otherwise its pretty cumbersome to get it.
type IUserData = InstanceType<typeof NcSelectUsers>['$props']['options'][number]🏁 Checklist
stable8for maintained Vue 2 version or not applicable