Skip to content

Comments

fix(NcInputField): Helper message word-break on Chrome#8128

Merged
artonge merged 1 commit intomainfrom
artonge/fix/word-break-on-chrome
Feb 4, 2026
Merged

fix(NcInputField): Helper message word-break on Chrome#8128
artonge merged 1 commit intomainfrom
artonge/fix/word-break-on-chrome

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Jan 28, 2026

Without it, the message does not break and increase the size of its container.
Couldn't test locally because linking @nc/vue fails, but tested manually by changing the CSS in the browser.

Browser Before After
Firefox image image
Chrome Screenshot From 2026-01-28 12-11-21 image

@artonge artonge self-assigned this Jan 28, 2026
@artonge artonge requested a review from susnux January 28, 2026 11:15
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.77%. Comparing base (c856de0) to head (a0b197c).
⚠️ Report is 47 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8128   +/-   ##
=======================================
  Coverage   52.77%   52.77%           
=======================================
  Files         103      103           
  Lines        3348     3348           
  Branches      976      976           
=======================================
  Hits         1767     1767           
  Misses       1333     1333           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge added 3. to review Waiting for reviews component Component discussion and/or suggestion feature: input-field Covering the InputField, TextField, ... labels Jan 28, 2026
Without it, the message does not break and increase the size of its container.

Signed-off-by: Louis Chmn <[email protected]>
@artonge artonge force-pushed the artonge/fix/word-break-on-chrome branch from 8f26593 to a0b197c Compare January 28, 2026 11:30
@susnux
Copy link
Contributor

susnux commented Jan 28, 2026

Couldn't test locally because linking @nc/vue fails, but tested manually by changing the CSS in the browser.

You need to use npm pack and then use the package in server (use "@nextcloud/files": "file:/path/to/nc/vue/package.tgz" in package.json).

Helper message word-break on Chrome

It seems like everything working fine in Chrome is broken in FF and vice-versa 😅

@artonge artonge marked this pull request as ready for review January 29, 2026 16:59
@artonge artonge added the bug Something isn't working label Jan 29, 2026
@artonge
Copy link
Contributor Author

artonge commented Jan 29, 2026

/backport to stable8

@artonge
Copy link
Contributor Author

artonge commented Jan 29, 2026

Tested, thanks

display: flex;
align-items: center;
color: var(--color-text-maxcontrast);
word-break: break-all;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if break-word looks better but not really sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would, but is deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artonge artonge marked this pull request as draft February 4, 2026 11:46
@artonge artonge marked this pull request as ready for review February 4, 2026 11:47
@artonge artonge merged commit 23d0966 into main Feb 4, 2026
31 checks passed
@artonge artonge deleted the artonge/fix/word-break-on-chrome branch February 4, 2026 11:48
@artonge artonge mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working component Component discussion and/or suggestion feature: input-field Covering the InputField, TextField, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants