Skip to content

Comments

feat(NcProgresBar): add showValue prop to show the progress value#8120

Merged
ShGKme merged 1 commit intonextcloud-libraries:mainfrom
nikhil2297:feat/progress-bar-value-label
Jan 27, 2026
Merged

feat(NcProgresBar): add showValue prop to show the progress value#8120
ShGKme merged 1 commit intonextcloud-libraries:mainfrom
nikhil2297:feat/progress-bar-value-label

Conversation

@nikhil2297
Copy link
Contributor

@nikhil2297 nikhil2297 commented Jan 25, 2026 •
edited by ShGKme
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Show value label only for linear progress bar
  • Update component documentation if needed

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@nikhil2297 nikhil2297 mentioned this pull request Jan 25, 2026
Closed
@codecov
Copy link

codecov bot commented Jan 26, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.77%. Comparing base (dbbdf69) to head (cc9183d).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8120   +/-   ##
=======================================
  Coverage   52.77%   52.77%           
=======================================
  Files         103      103           
  Lines        3348     3348           
  Branches      976      976           
=======================================
  Hits         1767     1767           
  Misses       1333     1333           
  Partials      248      248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ShGKme
ShGKme requested changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change. Left some comments, mostly about code style, but using unknown CSS variable --color-text-secondary is a blocking issue.

@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews labels Jan 26, 2026
@ShGKme ShGKme added this to the 9.5.0 milestone Jan 26, 2026
@ShGKme ShGKme changed the title feat(NcProgresBar): show progress value only for linear type feat(NcProgresBar): add showValue prop to show the progress value Jan 26, 2026
@ShGKme
Copy link
Contributor

ShGKme commented Jan 26, 2026

/backport to stable8

@nikhil2297
Copy link
Contributor Author

nikhil2297 commented Jan 26, 2026

@ShGKme - I've made all the suggested changes. Let me know if anything else needs to be addressed.

@nikhil2297 nikhil2297 requested a review from ShGKme January 26, 2026 18:45
ShGKme
ShGKme reviewed Jan 26, 2026
View reviewed changes
@ShGKme ShGKme requested a review from kra-mo January 26, 2026 20:31
@ShGKme
Copy link
Contributor

ShGKme commented Jan 26, 2026

Requesting desiner's review in addition

ShGKme
ShGKme approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now code-wise. Could you squash it into a single commit?

Waiting for a design review then.

@nikhil2297 nikhil2297 force-pushed the feat/progress-bar-value-label branch from 8145b8f to 62bd8b9 Compare January 26, 2026 21:44
@nikhil2297
Copy link
Contributor Author

nikhil2297 commented Jan 26, 2026

Looks good now code-wise. Could you squash it into a single commit?

Waiting for a design review then.

Done.

@nikhil2297 nikhil2297 requested a review from ShGKme January 26, 2026 21:45
kra-mo
kra-mo approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from the design side

@ShGKme
Copy link
Contributor

ShGKme commented Jan 27, 2026

@nikhil2297 Your name in DCO (commit description) and in git config (commiter name) is different.

@nikhil2297 @ShGKme
feat(NcProgressBar): show progress value for linear type and imporve …
cc9183d 
…styles and Improve BEM naming, use the correct variable and update code style

Co-authored-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: nikhil2297 <[email protected]>
@nikhil2297 nikhil2297 force-pushed the feat/progress-bar-value-label branch from 62bd8b9 to cc9183d Compare January 27, 2026 17:50
@nikhil2297
Copy link
Contributor Author

nikhil2297 commented Jan 27, 2026

@nikhil2297 Your name in DCO (commit description) and in git config (commiter name) is different.

I've fixed it.

@ShGKme ShGKme merged commit c856de0 into nextcloud-libraries:main Jan 27, 2026
24 checks passed
@artonge artonge mentioned this pull request Feb 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@kra-mo kra-mo kra-mo approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request enhancement New feature or request

Projects

None yet

Milestone

9.5.0

Development

Successfully merging this pull request may close these issues.

[NcProgressBar] No way to display numeric percentage value (value is never rendered as text)

3 participants

@nikhil2297 @ShGKme @kra-mo