Skip to content

Comments

fix: logger is not defined#7944

Merged
skjnldsv merged 1 commit intomainfrom
fix/logger-undefined-error
Dec 3, 2025
Merged

fix: logger is not defined#7944
skjnldsv merged 1 commit intomainfrom
fix/logger-undefined-error

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 2, 2025 •
edited
Loading

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added this to the 9.3.1 milestone Dec 2, 2025
@ShGKme ShGKme requested a review from SystemKeeper December 2, 2025 09:48
@ShGKme ShGKme self-assigned this Dec 2, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.99%. Comparing base (7873fd9) to head (39f55f9).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7944      +/-   ##
==========================================
+ Coverage   52.96%   52.99%   +0.03%     
==========================================
  Files         100      100              
  Lines        3119     3119              
  Branches      868      867       -1     
==========================================
+ Hits         1652     1653       +1     
+ Misses       1229     1228       -1     
  Partials      238      238

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme force-pushed the fix/logger-undefined-error branch from f444a98 to 0887db0 Compare December 2, 2025 10:11
@ShGKme
fix: logger is not defined
39f55f9 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme force-pushed the fix/logger-undefined-error branch from 0887db0 to 39f55f9 Compare December 2, 2025 10:13
@ShGKme ShGKme changed the title fix(NcRelatedResourcesPanel): logger is not defined fix: logger is not defined Dec 2, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 2, 2025

Added 2 more components, including one with loger instead of logger.

Checking why it is not handled by ESLint

@skjnldsv skjnldsv merged commit c752c54 into main Dec 3, 2025
27 checks passed
@skjnldsv skjnldsv deleted the fix/logger-undefined-error branch December 3, 2025 07:37
@skjnldsv skjnldsv mentioned this pull request Dec 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@ShGKme ShGKme

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

9.3.1

Development

Successfully merging this pull request may close these issues.

ReferenceError: logger is not defined

3 participants

@ShGKme @SystemKeeper @skjnldsv