Skip to content

Comments

[stable8] fix(NcAvatar): do no request avatar image if icon slot provided#7896

Merged
Antreesy merged 2 commits intostable8from
backport/7891/stable8
Nov 24, 2025
Merged

[stable8] fix(NcAvatar): do no request avatar image if icon slot provided#7896
Antreesy merged 2 commits intostable8from
backport/7891/stable8

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 20, 2025

Backport of #7891

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Nov 20, 2025
@backportbot backportbot bot added this to the 8.35.0 milestone Nov 20, 2025
@Antreesy Antreesy force-pushed the backport/7891/stable8 branch from 2391630 to 8e202ea Compare November 20, 2025 12:39
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical, should work on Vue2 as well

@Antreesy Antreesy marked this pull request as ready for review November 20, 2025 12:43
@Antreesy Antreesy force-pushed the backport/7891/stable8 branch from 8e202ea to 3d45f69 Compare November 20, 2025 16:58
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.46%. Comparing base (a7b9664) to head (96b1b96).
⚠️ Report is 3 commits behind head on stable8.

Files with missing lines Patch % Lines
src/mixins/userStatus.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #7896      +/-   ##
===========================================
+ Coverage    45.38%   45.46%   +0.08%     
===========================================
  Files          192      192              
  Lines         4768     4768              
  Branches      1229     1172      -57     
===========================================
+ Hits          2164     2168       +4     
  Misses        2508     2508              
+ Partials        96       92       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy Antreesy force-pushed the backport/7891/stable8 branch from 3d45f69 to 96b1b96 Compare November 24, 2025 09:30
@Antreesy Antreesy merged commit 191cf0c into stable8 Nov 24, 2025
19 of 21 checks passed
@Antreesy Antreesy deleted the backport/7891/stable8 branch November 24, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants