Skip to content

Comments

[stable8] fix(NcAppSettingsDialog): set box-sizing: border-box for the new design#7888

Merged
susnux merged 1 commit intostable8from
fix/NcAppSettings-Dialog--box-sizing
Nov 20, 2025
Merged

[stable8] fix(NcAppSettingsDialog): set box-sizing: border-box for the new design#7888
susnux merged 1 commit intostable8from
fix/NcAppSettings-Dialog--box-sizing

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 19, 2025

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added this to the 8.35.0 milestone Nov 19, 2025
@ShGKme ShGKme requested review from GVodyanov and susnux November 19, 2025 13:05
@ShGKme ShGKme self-assigned this Nov 19, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.38%. Comparing base (c5ee4b7) to head (39416c7).
⚠️ Report is 13 commits behind head on stable8.

Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #7888      +/-   ##
===========================================
+ Coverage    45.08%   45.38%   +0.30%     
===========================================
  Files          191      192       +1     
  Lines         4749     4768      +19     
  Branches      1226     1171      -55     
===========================================
+ Hits          2141     2164      +23     
+ Misses        2512     2510       -2     
+ Partials        96       94       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme requested a review from Antreesy November 19, 2025 13:09
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me, better to test for Vue 2 apps

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is a bit weird but ok

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 19, 2025

name is a bit weird but ok

You can make a suggestion for the name

@susnux susnux merged commit d55fbbe into stable8 Nov 20, 2025
19 of 21 checks passed
@susnux susnux deleted the fix/NcAppSettings-Dialog--box-sizing branch November 20, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants