Skip to content

Comments

[stable8] feat(NcRichText): add 'Copy to clipboard' button for code blocks#7877

Merged
susnux merged 3 commits intostable8from
backport/7841/stable8
Nov 18, 2025
Merged

[stable8] feat(NcRichText): add 'Copy to clipboard' button for code blocks#7877
susnux merged 3 commits intostable8from
backport/7841/stable8

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 17, 2025

Backport of #7841

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Antreesy, ShGKme and susnux November 17, 2025 13:18
@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Nov 17, 2025
@backportbot backportbot bot added this to the 8.35.0 milestone Nov 17, 2025
@Antreesy Antreesy marked this pull request as ready for review November 17, 2025 16:23
@Antreesy Antreesy force-pushed the backport/7841/stable8 branch from ebe4368 to 3fe21ef Compare November 17, 2025 16:23
@Antreesy
Copy link
Contributor

Rebased, adjusted to Vue2 rendering (https://v2.vuejs.org/v2/guide/render-function#The-Data-Object-In-Depth)
Button has :key attribute to be re-rendered after highlight.js is enabled

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.38%. Comparing base (5e07053) to head (0d664ee).
⚠️ Report is 4 commits behind head on stable8.

Files with missing lines Patch % Lines
...onents/NcFormBoxCopyButton/NcFormBoxCopyButton.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #7877      +/-   ##
===========================================
+ Coverage    45.08%   45.38%   +0.30%     
===========================================
  Files          191      192       +1     
  Lines         4749     4768      +19     
  Branches      1226     1229       +3     
===========================================
+ Hits          2141     2164      +23     
+ Misses        2512     2508       -4     
  Partials        96       96              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy Antreesy force-pushed the backport/7841/stable8 branch from 3fe21ef to 0d664ee Compare November 17, 2025 18:36
@susnux susnux merged commit c520b02 into stable8 Nov 18, 2025
19 of 21 checks passed
@susnux susnux deleted the backport/7841/stable8 branch November 18, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants