Skip to content

Comments

[stable8] fix(NcPasswordField): respect checkPasswordStrength for input validation#7846

Merged
ShGKme merged 1 commit intostable8from
backport/7845/stable8
Nov 12, 2025
Merged

[stable8] fix(NcPasswordField): respect checkPasswordStrength for input validation#7846
ShGKme merged 1 commit intostable8from
backport/7845/stable8

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

Backport of #7845
default value is changed, but it's neglectible as it just removes the input attribute

@Antreesy Antreesy added this to the 8.34.0 milestone Nov 12, 2025
@Antreesy Antreesy requested review from ShGKme and susnux November 12, 2025 16:16
@Antreesy Antreesy self-assigned this Nov 12, 2025
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.62%. Comparing base (242f14f) to head (ac8dafd).
⚠️ Report is 8 commits behind head on stable8.

Additional details and impacted files
@@           Coverage Diff            @@
##           stable8    #7846   +/-   ##
========================================
  Coverage    44.61%   44.62%           
========================================
  Files          188      188           
  Lines         4711     4706    -5     
  Branches      1226     1165   -61     
========================================
- Hits          2102     2100    -2     
+ Misses        2514     2513    -1     
+ Partials        95       93    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme merged commit 8fd8221 into stable8 Nov 12, 2025
19 of 21 checks passed
@ShGKme ShGKme deleted the backport/7845/stable8 branch November 12, 2025 19:24
@ShGKme ShGKme modified the milestones: 8.34.0, 8.35.0 Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: input-field Covering the InputField, TextField, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants