[stable8] fix(NcSelectUsers): fix using of v-model in Vue 2#7032
Merged
[stable8] fix(NcSelectUsers): fix using of v-model in Vue 2#7032
Conversation
Antreesy
added
bug
Antreesy
force-pushed
the
fix/stable8/nc-select-users
branch
from
01d7f69 to
75e6606
Compare
Antreesy
changed the title
susnux
reviewed
Jun 10, 2025
Comment on lines
387
to
394
| <script> | ||
| /** For backward compatibility with Vue 2 */ | ||
| export default { | ||
| model: { | ||
| prop: 'modelValue', | ||
| event: 'update:modelValue', | ||
| }, | ||
| } |
Contributor
There was a problem hiding this comment.
Can we move this above template? script - template - script seems weird
susnux
approved these changes
Jun 10, 2025
ShGKme
approved these changes
Jun 10, 2025
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/stable8/nc-select-users
branch
from
75e6606 to
fd50f51
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
v-modelusage in Vue 2 (for backward compatibility with main branch)🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable