feat!: split NcSelect super component into NcSelect and NcSelectUsers#6732
Merged
feat!: split NcSelect super component into NcSelect and NcSelectUsers#6732
NcSelect super component into NcSelect and NcSelectUsers#6732Conversation
susnux
added
enhancement
st3iny
reviewed
Apr 16, 2025
Contributor
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
I tested using the styleguide and it seems to work. However, the NcSelect examples seem to be broken but work on main. Is that related?
…th default value true Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/user-select
branch
from
ee6ca71 to
0c1c4c1
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/user-select
branch
from
0c1c4c1 to
d8ca52c
Compare
Contributor
Author
Yes it was, it is now fixed. Accidentally removed the default value. |
st3iny
approved these changes
Apr 16, 2025
This was referenced Apr 16, 2025
ShGKme
reviewed
Apr 16, 2025
Comment on lines
+216
to
+222
| defineProps<{ | ||
| /** | ||
| * `aria-label` for the clear input button. | ||
| * | ||
| * @default 'Clear selected' | ||
| */ | ||
| ariaLabelClearSelected?: string |
Contributor
There was a problem hiding this comment.
Duplicating everything looks painful, but the only option is if we have one component in JS and another in TS.
Contributor
Author
There was a problem hiding this comment.
I want to migrate select to TS someday we can cleanup then 😔
Contributor
There was a problem hiding this comment.
Then we need the type from vue-select
ShGKme
approved these changes
Apr 16, 2025
ShGKme
changed the title
NcSelect super component into NcSelect and NcSelectUsersNcSelect super component into NcSelect and NcSelectUsers
Contributor
Author
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@nextcloud/vue v9breaking changes #6384NcSelectUsers(naming similar toNcSelectTags) component to splitNcSelectsuper componentuser-selectprop ofNcSelectNcSelectUsersto Typescriptuser-selectproperty and behavior fromNcSelectThe first two commits would need to be backported to v8 for forward compatibility.
🏁 Checklist
stable8for maintained Vue 2 version.