fix(NcInputField): Make sure label and placeholder is not jumping#5821
Merged
fix(NcInputField): Make sure label and placeholder is not jumping#5821
Conversation
susnux
added
bug
Contributor
Author
|
/backport to next |
marcoambrosini
approved these changes
Jul 18, 2024
28 tasks
Rework layout logic to ensure the label is not jumping on focus. This was caused as our border width changes when focusing. Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
/backport to next |
2 tasks
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Rework layout logic to ensure the label is not jumping on focus. This was caused as our border width changes when focusing.
🖼️ Screenshots
Before
vokoscreenNG-2024-07-18_02-44-45.webm
After
vokoscreenNG-2024-07-18_02-42-29.webm
🏁 Checklist
nextrequested with a Vue 3 upgrade