fix(NcRichText): Allow to pass interactive widget toggle#5365
Merged
Conversation
Signed-off-by: Julius Härtl <[email protected]>
Contributor
Author
|
/backport to next |
Antreesy
approved these changes
Mar 7, 2024
Contributor
|
Not sure I understand how to test with interactive widgets, but couldn't test with Tables. Same issue in the console. I remembered, it was fixed somewhere...
Are they interactive? I expected interactive widgets to have "Enable interactive mode" button like in text:
|
Contributor
|
Sending a link to a text file looks like interactive, but also has errors and the text file is not loaded.
I'm not sure I correctly understand what are the steps to test PR |
Contributor
So far it works with 'Copy internal link" in Files Sharing tab and posting in the chat |
Contributor
|
For Images in Files:
But a text file is never loaded, and the message with the link even doesn't appear in the chat until reload. |
Signed-off-by: Julius Härtl <[email protected]>
susnux
approved these changes
Mar 8, 2024
Contributor
Author
|
I'll check those errors |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Talk we need to pass the interactive widget property over from NcRichText to be able to toggle it.
🏁 Checklist
nextrequested with a Vue 3 upgrade