fix(NcAvatar): Improve initials generation to filter out special characters#4737
Merged
raimund-schluessler merged 1 commit intomasterfrom Nov 2, 2023
Merged
fix(NcAvatar): Improve initials generation to filter out special characters#4737raimund-schluessler merged 1 commit intomasterfrom
raimund-schluessler merged 1 commit intomasterfrom
Conversation
susnux
added
bug
susnux
requested review from
ChristophWurst,
Pytal,
ShGKme,
raimund-schluessler and
skjnldsv
susnux
force-pushed
the
fix/ncavatar-initials
branch
2 times, most recently
from
d75be41 to
8392347
Compare
ShGKme
approved these changes
Nov 2, 2023
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Everything is good from the component side, but I'd discuss some changes in tests.
…acters Co-authored-by: Grigorii K. Shartsev <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/ncavatar-initials
branch
from
7f2ee0a to
ce3f168
Compare
ChristophWurst
approved these changes
Nov 2, 2023
Contributor
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Super nice!
If Nextcloud's back-end also still generates avatars we should at least create a ticket to also improve the handling there. This avoid inconsistencies between avatars generated on the front or the back.
raimund-schluessler
approved these changes
Nov 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
(.First Second Lastshould beFLand notFS).🖼️ Screenshots
🏁 Checklist