Conversation
susnux
added
bug
susnux
requested review from
JuliaKirschenheuter,
Pytal,
ShGKme and
raimund-schluessler
ShGKme
reviewed
Nov 1, 2023
susnux
force-pushed
the
fix/ncappsidebar-tabs-labelled
branch
from
2279274 to
db0f8c4
Compare
ShGKme
reviewed
Nov 2, 2023
…ledby` element does not exist Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/ncappsidebar-tabs-labelled
branch
from
db0f8c4 to
386796d
Compare
ShGKme
approved these changes
Nov 2, 2023
AndyScherzinger
approved these changes
Nov 2, 2023
JuliaKirschenheuter
approved these changes
Nov 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
If only one sidebar tab is shown, the tab header is missing. Thus we can not reference it for
aria-labelledbyand have to usearia-labelinstead.🏁 Checklist