Skip to content

Comments

fix(NcTimezonePicker): Allow to set ID of inner select component#4734

Merged
Pytal merged 1 commit intomasterfrom
fix/nc-timezone-picker-allow-uid
Nov 1, 2023
Merged

fix(NcTimezonePicker): Allow to set ID of inner select component#4734
Pytal merged 1 commit intomasterfrom
fix/nc-timezone-picker-allow-uid

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 1, 2023

☑️ Resolves

Allows to the the ID of the inner select so it can be referenced by labels.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Nov 1, 2023
ShGKme
ShGKme previously requested changes Nov 1, 2023
…able to reference it for labels

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/nc-timezone-picker-allow-uid branch from 9678f3c to 847f6aa Compare November 1, 2023 17:31
@susnux susnux requested a review from ShGKme November 1, 2023 17:31
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 1, 2023
@Pytal Pytal merged commit 6d55089 into master Nov 1, 2023
@Pytal Pytal deleted the fix/nc-timezone-picker-allow-uid branch November 1, 2023 17:35
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Nov 2, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: select Related to the NcSelect* components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants