Skip to content

Comments

fix(NcSelect): Ensure selected option has enough contrast when the menu is opened#4733

Merged
Pytal merged 1 commit intomasterfrom
fix/nc-select-selected-option-open
Nov 1, 2023
Merged

fix(NcSelect): Ensure selected option has enough contrast when the menu is opened#4733
Pytal merged 1 commit intomasterfrom
fix/nc-select-selected-option-open

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 1, 2023

☑️ Resolves

Make sure the currently active option has still enough contrast when the menu is opened, by dropping the opacity property but using max contrast color.

🖼️ Screenshots

🏚️ Before 🏡 After
before after

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 1, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenshot

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 1, 2023
@Pytal Pytal merged commit d2d0323 into master Nov 1, 2023
@Pytal Pytal deleted the fix/nc-select-selected-option-open branch November 1, 2023 17:17
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Nov 2, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants