Skip to content

Comments

Made description dynamic on related resources#4729

Merged
GretaD merged 1 commit intomasterfrom
enhanc/make-descr-dynamic
Nov 1, 2023
Merged

Made description dynamic on related resources#4729
GretaD merged 1 commit intomasterfrom
enhanc/make-descr-dynamic

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Oct 31, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
BEFORE Screenshot from 2023-10-31 14-52-33

🚧 Tasks

  • Make descr dynamic
  • Change the header styling to always be a primary colour

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@GretaD GretaD added the 2. developing Work in progress label Oct 31, 2023
@GretaD GretaD self-assigned this Oct 31, 2023
@GretaD GretaD marked this pull request as draft October 31, 2023 13:58
@GretaD GretaD requested review from Pytal and ShGKme November 1, 2023 12:21
@GretaD GretaD marked this pull request as ready for review November 1, 2023 12:21
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nitpick I have 😉

@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 1, 2023
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just squash your commits

@GretaD GretaD force-pushed the enhanc/make-descr-dynamic branch from f793687 to 887bf74 Compare November 1, 2023 13:04
@GretaD GretaD merged commit a62ee48 into master Nov 1, 2023
@GretaD GretaD deleted the enhanc/make-descr-dynamic branch November 1, 2023 13:07
@skjnldsv skjnldsv added enhancement New feature or request feature: related resources panel Related to the NcRelatedResourcesPanel component labels Nov 3, 2023
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 3, 2023

Please set appropriate bug or enhancement labels next time 👍

@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: related resources panel Related to the NcRelatedResourcesPanel component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants