Skip to content

Comments

fix(NcActions): Detect navigation menu links correctly#4707

Merged
Pytal merged 1 commit intomasterfrom
fix/actions-nav
Oct 31, 2023
Merged

fix(NcActions): Detect navigation menu links correctly#4707
Pytal merged 1 commit intomasterfrom
fix/actions-nav

Conversation

@Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 28, 2023 •
edited
Loading

Summary

  • Fix detection of navigation menu links with relative hrefs
  • Exclude anchor links

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Oct 28, 2023
@Pytal Pytal added this to the 8.0.0 milestone Oct 28, 2023
@Pytal Pytal self-assigned this Oct 28, 2023
@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 28, 2023
@Pytal Pytal marked this pull request as ready for review October 30, 2023 23:31
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 30, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 31, 2023
@Pytal Pytal merged commit c2095bf into master Oct 31, 2023
@Pytal Pytal deleted the fix/actions-nav branch October 31, 2023 16:10
@Pytal Pytal mentioned this pull request Oct 31, 2023
Closed
3 tasks
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal @AndyScherzinger @ShGKme