fix(NcAvatar): make it a span phrasing element#4674
Merged
Conversation
It is required to allow using avatar as a phrasing content, for example, as a button content. Signed-off-by: Grigorii K. Shartsev <[email protected]>
184c60d to
4e05761
Compare
Pytal
approved these changes
Oct 19, 2023
JuliaKirschenheuter
approved these changes
Oct 19, 2023
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is required to allow using avatar as a phrasing content, for example, as a button content.
☑️ Resolves
Sometimes we use
NcAvataras a button content, for example, as a Popover trigger on the main UserMenu.HTML does not allow this. Button should have only so-called phrasing (aca inline text) content.
This PR makes
NcAvataraspaninstead of adiv.For some places it doesn't change anything in the layout, because it has
display: inline-block, orposition: absolute. In other placesdisplay: block;was implicitly added.Alternative solution: make
NcHeaderItemnot a<button>but adiv[role=button].#4675
🖼️ Screenshots
No visual changes
🚧 Tasks
divwith aspandisplay: block;where it is required.🏁 Checklist