Skip to content

Comments

fix(NcActions): do not pass popoverBaseClass as an attr to NcPopover#4673

Merged
ShGKme merged 1 commit intomasterfrom
fix/actions--html-validation
Oct 19, 2023
Merged

fix(NcActions): do not pass popoverBaseClass as an attr to NcPopover#4673
ShGKme merged 1 commit intomasterfrom
fix/actions--html-validation

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 19, 2023

☑️ Resolves

Currently for some reason all props of NcActions are passed twice to NcPopover: as props and as attrs

nextcloud-vue/src/components/NcActions/NcActions.vue

Lines 1080 to 1105 in d939939

return h('NcPopover',
{
ref: 'popover',
props: {
delay: 0,
handleResize: true,
shown: this.opened,
placement: this.placement,
boundary: this.boundariesElement,
container: this.container,
popoverBaseClass: 'action-item__popper',
setReturnFocus: this.$refs.menuButton?.$el,
},
// For some reason the popover component
// does not react to props given under the 'props' key,
// so we use both 'attrs' and 'props'
attrs: {
delay: 0,
handleResize: true,
shown: this.opened,
placement: this.placement,
boundary: this.boundariesElement,
container: this.container,
...this.manualOpen && { triggers: [] },
popoverBaseClass: 'action-item__popper',
},

But popoverBaseClass is not a NcPopover prop but NcActions own prop. It should not be passed as an attribute. It results with an invalid popoverbaseclass attribute on an HTML element.

🖼️ Screenshots

No visual changes

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Oct 19, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Oct 19, 2023
@ShGKme ShGKme self-assigned this Oct 19, 2023
@ShGKme ShGKme changed the title fix(NcActions): do not pass popoverBaseClass as an attr fix(NcActions): do not pass popoverBaseClass as an attr to NcPopover Oct 19, 2023
@szaimen szaimen removed their request for review October 19, 2023 13:22
@ShGKme ShGKme merged commit cbe883d into master Oct 19, 2023
@ShGKme ShGKme deleted the fix/actions--html-validation branch October 19, 2023 13:49
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels

3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ShGKme @susnux @raimund-schluessler