fix(NcTextField): do not pass all props to InputField BY stop passing $props#4665
Closed
fix(NcTextField): do not pass all props to InputField BY stop passing $props#4665
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
susnux
approved these changes
Oct 19, 2023
Pytal
reviewed
Oct 19, 2023
| props: { | ||
| ...NcInputField.props, | ||
| /** | ||
| * Any NcInputField props |
Contributor
There was a problem hiding this comment.
Suggested change
| * Any NcInputField props | |
| * Any [NcInputField](#/Components/NcFields?id=ncinputfield) props |
Contributor
Author
There was a problem hiding this comment.
I didn't know that's possible =D
JuliaKirschenheuter
approved these changes
Oct 19, 2023
Pytal
approved these changes
Oct 19, 2023
Contributor
Author
|
Closing in flavor of an alternative approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
HTML Validation issue.
Currently
NcTextFieldpasses both$attrsand$propsto theNcInputField.While passing
$attrsmakes sense, passing$propsis valid only when both components have exactly the same props. But they don't.NcTextFieldhas its own proptrailingButtonIconand may have more props in the future.Proposal: same as
NcPopoverCurrently, all
NcInputFieldprops are defined asNcTextFieldprops. But actually they are notNcTextFieldprops. They are not used butNcTextField, it is not aware of most of them at all. It is used only for styleguidist documentation generation.The proposal is to make component a transparent wrapper by passing attributes directly, defining only necessary props.
Alternative solution:
While I personally prefer this solution,there is an alternative: filter out props on proxying.See: #4666
🖼️ Screenshots
trailingbuttoniconis not a valid<input>attribute.🏁 Checklist