feat(NcIconSvgWrapper): allow to render raw svg paths#4643
Merged
Conversation
raimund-schluessler
added
2. developing
susnux
previously approved these changes
Oct 13, 2023
susnux
dismissed
their stale review
Did not meant to approve, should be a comment
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
feat/noid/svg-path
branch
from
a56fd10 to
f597e50
Compare
Contributor
Author
Yeah, you were a bit to fast to review, I wasn't done yet 🙈 🙂 I also had to set the |
raimund-schluessler
requested review from
Pytal,
ShGKme,
marcoambrosini and
skjnldsv
raimund-schluessler
added
3. to review
raimund-schluessler
changed the title
Pytal
reviewed
Oct 13, 2023
Contributor
Pytal
left a comment
Pytal
left a comment
There was a problem hiding this comment.
Can we reduce duplication by putting the identical props in a computed property then v-bind them ?
Signed-off-by: Raimund Schlüßler <[email protected]>
Contributor
Author
Sure, why not. I adjusted it. |
ShGKme
approved these changes
Oct 13, 2023
Pytal
approved these changes
Oct 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This allows to render raw SVG paths which prevents the overhead of having to sanitize the SVG icon for use in
v-html.