feat(NcTextArea): implement new textarea component#4605
Conversation
eedddeb to
5ff9853
Compare
Signed-off-by: Richard Steinmetz <[email protected]>
5ff9853 to
4d09444
Compare
ShGKme
left a comment
There was a problem hiding this comment.
At a glance, this component looks very similar to NcInputField with similar interface, states, helper/hint text, public methods, and label. Except a trailing button.
Could it be possible to add a new prop in NcInputField like multiline/textarea instead and use dynamic component?
Maybe making this component a wrapper around NcInputField like NcTextField if we need to assign more custom things.
That was my plan at first but doing so would require a lot of hacks. For example trailing buttons, and leading icons don't make sense here. They look weird as the text extends to multiple lines. The success and error states are tied to leading icons in I went with a custom component to reduce complexity and narrow the scope of |
|
I agree with @st3iny, the NcInputField is a wrapper around the native input field and this one is a wrapper around the native textarea. |
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
None
🏁 Checklist