Conversation
susnux
added
3. to review
susnux
requested review from
JuliaKirschenheuter,
Pytal,
ShGKme and
raimund-schluessler
susnux
force-pushed
the
fix/a11y-status-on-avatar
branch
2 times, most recently
from
919c07e to
bc6afd2
Compare
Pytal
suggested changes
Oct 3, 2023
susnux
force-pushed
the
fix/a11y-status-on-avatar
branch
from
bc6afd2 to
bb069b5
Compare
susnux
force-pushed
the
fix/a11y-status-on-avatar
branch
from
bb069b5 to
33bbedc
Compare
ShGKme
reviewed
Oct 4, 2023
Comment on lines
-124
to
+127
| @click="toggleMenu" | ||
| @keydown.enter="toggleMenu"> | ||
| v-on="hasMenu ? { | ||
| click: toggleMenu, | ||
| keydown: toggleMenu, | ||
| } : null"> |
Contributor
There was a problem hiding this comment.
IMO, we can move hasMenu check to the events handler toggleMenu. Then we wouldn't need to implement Vue's functionality manually and template would be clearer without 4-lines computing directive.
Contributor
Author
There was a problem hiding this comment.
No I explicitly moved it to the template, otherwise the listeners would always be added.
But when there is no menu we should not have any listeners, because that element is not interactive.
susnux
force-pushed
the
fix/a11y-status-on-avatar
branch
from
33bbedc to
936d82a
Compare
ShGKme
reviewed
Oct 6, 2023
susnux
force-pushed
the
fix/a11y-status-on-avatar
branch
2 times, most recently
from
174c2af to
b26b584
Compare
Pytal
approved these changes
Oct 7, 2023
ShGKme
approved these changes
Oct 7, 2023
JuliaKirschenheuter
approved these changes
Oct 11, 2023
susnux
force-pushed
the
fix/a11y-status-on-avatar
branch
from
b26b584 to
c40b703
Compare
…any visible status indicator Signed-off-by: Ferdinand Thiessen <[email protected]>
…e component is not interactive Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/a11y-status-on-avatar
branch
from
c40b703 to
6b1aec4
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
No visible changes, just enforce the aria label to include the user status if there is any visible indicator (like when used in
NcSelect).Also translate
dndbecause that abbreviation is quite confusion (I had to search for it, as I was thinking about a pen and paper game 😉 ).🏁 Checklist