feat(NcDialog): New component (moved from @nextcloud/dialogs)#4550
feat(NcDialog): New component (moved from @nextcloud/dialogs)#4550
@nextcloud/dialogs)#4550Conversation
susnux
added
enhancement
susnux
requested review from
ShGKme,
artonge,
raimund-schluessler,
skjnldsv and
szaimen
|
Just tested and there are some issues on mobile: |
|
Seems to be browser related as your browser overlays the bar with the content? |
|
Still the buttons should not appear at the very bottom. Is this possible? |
Are you sure? I think it is more intuitive to have them on the bottom on mobile.
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@szaimen would you mind if we do a design review session later (maybe schedule it with the design team) and for the beginning just merge it as is? BTW on material dialogs look like this on mobile: |
|
@szaimen reworked the small dialogs, now it looks like normal dialogs: |
susnux
force-pushed
the
feat/nc-dialog-v2
branch
3 times, most recently
from
7e29abc to
bd05641
Compare
There was a problem hiding this comment.
This looks good now from design perspective :)
However I guess the a11y team should look over it as it might not be 100% accessible?
cc @JuliaKirschenheuter @ShGKme @Pytal
See e.g.
I think this is a regression of the double outline of the button focus-visible. We probably should add a margin of 4px to all buttons to ensure there is space for showing the outline. |
susnux
force-pushed
the
feat/nc-dialog-v2
branch
from
bd05641 to
745dc22
Compare
|
Nevertheless fixed this for now here by adding a 4px margin to the actions (while still keeping the padding consistent):
|
…odal` component Signed-off-by: Ferdinand Thiessen <[email protected]>
… as the base Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/nc-dialog-v2
branch
from
745dc22 to
b1164ed
Compare
4 participants
☑️ Resolves
AppSettingsDialogdoes scroll the section list when clicking on entry #4348 (fixed by migrating AppSettingsDialog to NcDialog base)@nextcloud/dialogs) #4415 (without Typescript and fancy<script setup>).Introduces NcDialog as a generic base Dialog component, while NcModal is simply a base for modals like the viewer, NcDialog provides a convenient interface to define dialogs (see example).
The new FilePicker of the
@nextcloud/dialogspackage is based on top of it.🖼️ Screenshots
One example dialog:
🏁 Checklist