Conversation
… scrolled. Fixes #3118 Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
bug
susnux
requested review from
a team,
ChristophWurst,
marcoambrosini and
raimund-schluessler
Contributor
|
@susnux Awesome that you included tests, but Runner2 gives this error: However, it passes anyway, so I don't know what the error means 🙈 |
Contributor
Author
It means Typescript is missing the type definitions for that vue file, as it is written in Javascript and we do not provide any typings for it. I think to silence that issue I will have to add a declaration shim for tests :) |
st3iny
approved these changes
Jul 24, 2023
Contributor
There was a problem hiding this comment.
Tested in calendar and works.
Some hacks need to be reverted and I added a note to #4223.
Exemplary patch for calendar
diff --git a/css/app-settings.scss b/css/app-settings.scss
index 5e96ae0e6..5ae9a0744 100644
--- a/css/app-settings.scss
+++ b/css/app-settings.scss
@@ -86,8 +86,6 @@
.shortcut-overview-modal {
.modal-container {
- display: flex !important;
- flex-wrap: wrap;
padding: 0 12px 12px 12px !important;
* {
skjnldsv
approved these changes
Aug 2, 2023
Merged
Contributor
Author
|
/backport to stable7 |
Contributor
Raised an issue 4627 for tracking this |
This was referenced Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Ensures that the close button of the modal is always visible, even if the content overflows the container and is scrolled.
🧪 Cypress test included.
🏁 Checklist