Allow preventing link insertion in RichContentEditable#3890
Merged
Conversation
julien-nc
added
enhancement
julien-nc
requested review from
juliusknorr,
nickvergessen and
raimund-schluessler
juliusknorr
reviewed
Mar 15, 2023
| this.updateValue(this.$refs.contenteditable.innerHTML) | ||
| const eventData = { | ||
| link, | ||
| run: true, |
Contributor
There was a problem hiding this comment.
Suggested change
| run: true, | |
| insertText: true, |
Might make it a bit clearer what this is about.
julien-nc
force-pushed
the
enh/noid/richcontenteditable-prevent-picker-insertion
branch
from
102e4db to
4fe5085
Compare
julien-nc
force-pushed
the
enh/noid/richcontenteditable-prevent-picker-insertion
branch
from
4fe5085 to
84d339d
Compare
julien-nc
force-pushed
the
enh/noid/richcontenteditable-prevent-picker-insertion
branch
from
84d339d to
8e0783d
Compare
juliusknorr
approved these changes
Mar 24, 2023
Contributor
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Haven't tested but code looks good
susnux
added
3. to review
…pper context prevent text insertion Signed-off-by: Julien Veyssier <[email protected]>
susnux
force-pushed
the
enh/noid/richcontenteditable-prevent-picker-insertion
branch
from
8e0783d to
e4319d3
Compare
nickvergessen
requested review from
Antreesy
and removed request for
nickvergessen
Antreesy
approved these changes
Oct 21, 2023
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Works, tested against Talk
Note for self:
<NcRichContenteditable @smart-picker-submit="handleSmartPickerSubmit" />
handleSmartPickerSubmit(event) {
console.log(event)
event.insertText = false
},
susnux
approved these changes
Nov 1, 2023
susnux
deleted the
enh/noid/richcontenteditable-prevent-picker-insertion
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getting a picker result, emit an event so parent components can prevent it to be inserted in the content and add some custom processing.
This could be useful in Talk when getting an OpenStreetMap link. A location rich object could be shared instead of inserting the link.