Fix non-user avatar on complex background#3272
Merged
raimund-schluessler merged 1 commit intomasterfrom Sep 20, 2022
Merged
Conversation
ChristophWurst
added
bug
ChristophWurst
requested review from
CarlSchwan,
GretaD,
jancborchardt,
raimund-schluessler and
tcitworld
23 tasks
ChristophWurst
force-pushed
the
fix/avatar-on-complex-background
branch
2 times, most recently
from
88afaf1 to
7bcffb5
Compare
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/avatar-on-complex-background
branch
from
7bcffb5 to
acdd3f2
Compare
raimund-schluessler
approved these changes
Sep 20, 2022
Contributor
raimund-schluessler
left a comment
raimund-schluessler
left a comment
There was a problem hiding this comment.
code-wise 👍
design-wise others have to decide
jancborchardt
approved these changes
Sep 20, 2022
Contributor
|
/backport to stable6 |
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered in nextcloud/contacts#2726
Due to the 0.1 alpha channel of the new avatars, the background potentially shows through. This is not expected nor does it look any good.