Fix for border-radius being too large for 3-line entries like in Mail#3136
Merged
juliusknorr merged 1 commit intomasterfrom Sep 2, 2022
Merged
Fix for border-radius being too large for 3-line entries like in Mail#3136juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
Signed-off-by: Jan C. Borchardt <[email protected]>
jancborchardt
added
enhancement
jancborchardt
requested review from
JuliaKirschenheuter,
juliusknorr and
marcoambrosini
Merged
marcoambrosini
approved these changes
Aug 31, 2022
Contributor
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
👌
Could you move your comment to the commit message maybe?
Contributor
Author
I’d say it should stay there as it’s quite a specific value? As said, ideally variables are used. Like, commented code is good, no? :D |
Contributor
Author
|
Can we merge this @CarlSchwan @marcoambrosini @juliushaertl? :) |
juliusknorr
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix what @marcoambrosini mentioned at #3055 (comment)
44px avatar size / 2 + 8px padding, and 2px for better visual quality
The avatar size and padding should ideally be taken from variables but I couldn’t see the relevant ones in the variables file.
--default-grid-baseline: 4px;is added by @juliushaertl in another pull request.Unfortunately can’t do screenshots as I can’t see how to add the third line to the component in the docs.