Merged
Conversation
juliusknorr
added
enhancement
This was referenced Aug 26, 2022
juliusknorr
force-pushed
the
poc/redesign
branch
from
24f1714 to
3499cc2
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
poc/redesign
branch
from
3499cc2 to
f664314
Compare
Contributor
Author
|
@ChristophWurst Pushed a few more adjustments for the app content list layout that is used in mail, scrolling in general works, just the message list doesn't seem to be handled entirely by the vue components so header__button element needs some adjustments with its contents. |
CarlSchwan
approved these changes
Sep 1, 2022
skjnldsv
approved these changes
Sep 1, 2022
Merged
juliusknorr
dismissed
skjnldsv’s stale review
Branched off stable6 to move on
CarlSchwan
approved these changes
Sep 1, 2022
juliusknorr
requested review from
ChristophWurst,
PVince81,
raimund-schluessler and
skjnldsv
raimund-schluessler
approved these changes
Sep 1, 2022
Contributor
raimund-schluessler
left a comment
raimund-schluessler
left a comment
There was a problem hiding this comment.
Code looks ok, but I didn't test it. However, I guess that's what the planned beta release is for 😄
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vue components implementation of nextcloud/server#33568