🥛 Make app navigation semi-transparent#3057
Merged
juliusknorr merged 1 commit intomasterfrom Aug 26, 2022
Merged
Conversation
Contributor
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good so far
Contributor
Author
|
the variables names will be changed because i didnt see julius pr: https://github.com/nextcloud/server/pull/33610/files but that doesnt change the result |
Contributor
|
Ah ok got it, then just use @juliushaertl’s variables, my comments are moot. :) |
This comment was marked as resolved.
This comment was marked as resolved.
GretaD
force-pushed
the
improve/app-navigation
branch
from
0d73e36 to
b908733
Compare
GretaD
added
3. to review
AndyScherzinger
changed the title
GretaD
requested review from
ChristophWurst,
jancborchardt,
juliusknorr and
marcoambrosini
juliusknorr
reviewed
Aug 26, 2022
juliusknorr
reviewed
Aug 26, 2022
ChristophWurst
approved these changes
Aug 26, 2022
Contributor
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
👍 code looks good
juliusknorr
approved these changes
Aug 26, 2022
Signed-off-by: greta <[email protected]>
GretaD
force-pushed
the
improve/app-navigation
branch
from
bac8924 to
5f59558
Compare
Contributor
|
@juliushaertl So this will work with NC 24 and below as well, right? |
Contributor
|
Yes, as we have the fallback to the previous values in place. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3047