Skip to content

Comments

📰 Update AppNavigationItem design#3056

Merged
marcoambrosini merged 5 commits intomasterfrom
feature/update-appnavigationitem-design
Aug 23, 2022
Merged

📰 Update AppNavigationItem design#3056
marcoambrosini merged 5 commits intomasterfrom
feature/update-appnavigationitem-design

Conversation

@marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Aug 17, 2022

fix #3049

Screenshot 2022-08-17 at 16 34 48

Signed-off-by: Marco Ambrosini [email protected]

@marcoambrosini
Copy link
Contributor Author

marcoambrosini commented Aug 17, 2022

  • Make all trailing icons and button 44 wide

Copy link
Contributor

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndyScherzinger AndyScherzinger changed the title Update AppNavigationItem design 📰 Update AppNavigationItem design Aug 18, 2022
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but agree with @nickvergessen’s remark regarding animation speed variable use. :)

Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini marcoambrosini force-pushed the feature/update-appnavigationitem-design branch from 7c9bdb1 to ef3b1ab Compare August 23, 2022 08:48
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini marcoambrosini merged commit 793a880 into master Aug 23, 2022
@marcoambrosini marcoambrosini deleted the feature/update-appnavigationitem-design branch August 23, 2022 10:58
@skjnldsv skjnldsv mentioned this pull request Aug 23, 2022
@juliusknorr juliusknorr mentioned this pull request Aug 29, 2022
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💊 Pill-rounded navigation entries

5 participants