add role & aria-labels for accessibility#2696
Merged
nickvergessen merged 1 commit intomasterfrom Jul 15, 2022
Merged
Conversation
vanpertsch
added
2. developing
This was referenced May 18, 2022
Contributor
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
accessibility/modal-aria-labels
branch
from
01e59d9 to
58fb352
Compare
nickvergessen
added
3. to review
Contributor
|
Ready to review |
Pytal
approved these changes
Jul 14, 2022
vinicius73
approved these changes
Jul 15, 2022
This was referenced Jul 15, 2022
Contributor
|
/backport to stable5 |
|
The backport to stable5 failed. Please do this backport manually. |
Contributor
|
There is still no stable5 branch, but i guess we should create it from 5.3.x |
Contributor
|
There is now, see #2907 |
Contributor
|
I'll backport it manually |
Contributor
|
The ids might not be unique if there are multiple modals on the page. I think this needs to be enhanced with a randomly generated string, |
Contributor
|
The modals are not mounted until displayed. So should be fairly save for now? |
Contributor
Depends. I think I saw a case in an app where two modals appeared on top of each other. Don't remember where, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vanessa Pertsch [email protected]