Conversation
susnux
added
enhancement
skjnldsv
reviewed
Feb 27, 2025
Contributor
There was a problem hiding this comment.
Super good! Tested and works great!
We could need slight changes though:
- The speed can be cut of when estimating
(probably best to hide it when estimating ?)
- When very high speed, I barely got time to see the speed or time left, it jumps from "estimating" to "assembling", do you think we can do better here? 🤔
- When assembling, we should probably hide the cancel button ?
8 tasks
Contributor
Author
Thank you!
Makes sense, I will think of a good way :)
We can check the current speed if it will be just a few seconds and directly show "few seconds left" instead of estimating?
Makes sense! |
Contributor
Good option! 👍 |
This feature implements the following: - Implement the ETA class our selfe - Provide upload speed information in the ETA class - Move the ETA information to the uploader class - Remove custom ETA from uploader component and add uploading speed. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
"a few seconds left" is so long that there is no space. So we only show it when there is enough space - otherwise just as a title attribute. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
All points resolved I think :) |
Merged
skjnldsv
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature implements the following:
Due to the risks of something breaking this is 100% test covered (unit tests) and additionally added component tests for it.