fix: Do not depend on vue or vue-router for the public interface of OC.Files.Router#255
fix: Do not depend on vue or vue-router for the public interface of OC.Files.Router#255
OC.Files.Router#255Conversation
|
Do you have an example of such problems? |
|
When I checked the last time, some app used the route return by promise |
…OC.Files.Router` Instead bundle interfaces used on the specific server version. Signed-off-by: Ferdinand Thiessen <[email protected]>
cfedbcb to
cc9fd16
Compare
|
I am thinking of situations like having vue-router v4 but server is still using vue-router v3. Or later if we use vue router v4 and they change the interface we need to depend on multiple versions of vue-router for every server version. So we can instead bundle the types used. Myself I only have the problem of having two versions of vue and vue-router installed for vue 3 apps, leading to EOL warnings + unnecessary large |
But is it a problem? It is usually only a problem if you directly have conflicting dependencies and peer dependency of a dependency which is not the case for
Yes, but it is also solvable in
Yes, but for server it's less than 1% diff for So, IMO, there are no serious issues of having the correct type here. And if we need to get rid of it, we can at least provide a limited type for apps that currently use the |
I already changed it to the extracted interface instead of |
Having vue types is not a good idea, this will become a problem if you depend on multiple versions of vue-router.
So for this functions are basically only provided for triggering route changes, so we can simply set them toPromisereturn type.So we should bundle the exact types used on that exact server version.