fix!: make dirname and basename behave like PHP and Node#839
Merged
Conversation
There were some unexpected behavior (when expecting the same as Node.js or PHP do) in both methods. Those were "documented" in the tests but never fixed. Adjusted both functions to behave like Node.js and also in most cases like PHP. Signed-off-by: Ferdinand Thiessen <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
===========================================
+ Coverage 91.66% 100.00% +8.33%
===========================================
Files 1 1
Lines 36 45 +9
Branches 7 10 +3
===========================================
+ Hits 33 45 +12
+ Misses 3 0 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
artonge
approved these changes
Dec 16, 2025
Signed-off-by: Ferdinand Thiessen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some unexpected behavior (when expecting the same as Node.js or PHP do) in both methods.
Those were "documented" in the tests but never fixed. Adjusted both functions to behave like Node.js and also in most cases like PHP.
Due to the long standing todo lets consider this breaking an do a v3.