Conversation
susnux
added
enhancement
susnux
force-pushed
the
enh/use-nc-dialog
branch
from
89f256e to
ae3cf13
Compare
susnux
force-pushed
the
fix/nextcloud-vue
branch
from
6c28edd to
18e283b
Compare
susnux
force-pushed
the
enh/use-nc-dialog
branch
from
ae3cf13 to
a9f0c7c
Compare
Pytal
reviewed
Jan 22, 2024
JuliaKirschenheuter
approved these changes
Feb 6, 2024
emoral435
approved these changes
Feb 6, 2024
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
LGTM 🐘 Whether with a form or using our component, this works 👍
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
enh/use-nc-dialog
branch
from
a9f0c7c to
96bd433
Compare
susnux
force-pushed
the
enh/use-nc-dialog
branch
from
96bd433 to
70e96f2
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
enh/use-nc-dialog
branch
from
70e96f2 to
d8adb8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nextcloud/vueto allow stable version #693 first!Use NcDialog instead of NcModal, so we can reduce the boilerplate code (styles etc).
Screenshots
sorry forgot to switch to English language