Merged
Conversation
susnux
reviewed
Sep 8, 2025
susnux
reviewed
Sep 8, 2025
artonge
force-pushed
the
artonge/fix/helper_text_http_code
branch
4 times, most recently
from
b1a9a24 to
2165e32
Compare
susnux
approved these changes
Sep 8, 2025
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/helper_text_http_code
branch
from
2165e32 to
8292799
Compare
artonge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the helper text was not differentiating between errors, so all errors were displayed as a 403.
Would help investigate nextcloud/server#53472
This also fix a bug where the retry request would never fly if the error was not a 403.