Merged
Conversation
ShGKme
approved these changes
May 12, 2025
All vue modules used are declared already, so we only need to mock it for NcPasswordField as this is not yet migrated to Typescript. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/drop-unneeded-ts-declare
branch
from
2b2aa2d to
b7c93f9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ferdinand Thiessen <[email protected]>
artonge
reviewed
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All vue modules used are declared already, so we only need to mock it for NcPasswordField as this is not yet migrated to Typescript.