Skip to content

Comments

enh: Move package to vite for bundling + compress translations#781

Merged
susnux merged 1 commit intomasterfrom
enh/improve-package
Jan 10, 2024
Merged

enh: Move package to vite for bundling + compress translations#781
susnux merged 1 commit intomasterfrom
enh/improve-package

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 9, 2024

This includes a lot of changes:

  1. Move to vite for bundling (reduces configurations and dependencies)
  2. Compress translations by removing unneeded information, this reduces bundle size of using application by ~10kb
  3. Explicitly import moment with locales, otherwise the locales are not included in bundles when using tree shaking like vite (fixes Submission date not in locale format nextcloud/forms#1856 and fixes Datestrings from moment not correctly localized nextcloud/tasks#2448)

@susnux susnux force-pushed the enh/improve-package branch 6 times, most recently from a967ad2 to d0a6ca7 Compare January 9, 2024 23:23
Copy link

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well with the Tasks app 👍

@raimund-schluessler
Copy link

I suppose this will be 2.0.0 of nextcloud/moment?

@Chartman123
Copy link

I suppose this will be 2.0.0 of nextcloud/moment?

I'd expect to have a solution for #407 in a 2.0.0...

@raimund-schluessler
Copy link

I suppose this will be 2.0.0 of nextcloud/moment?

I'd expect to have a solution for #407 in a 2.0.0...

Well, I would not delay the next major release because of #407, because that will likely be a new package completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Datestrings from moment not correctly localized Submission date not in locale format

3 participants