fix(deps): migrate away from node-gettext#1087
Merged
ChristophWurst merged 1 commit intomainfrom May 6, 2025
Merged
Conversation
ChristophWurst
added
bug
st3iny
approved these changes
May 6, 2025
Contributor
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Need to run npm run l10n:extract and commit changes.
Looks good otherwise.
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/deps/no-node-gettext
branch
from
e76ae9b to
a991d20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the lead of nextcloud-libraries/nextcloud-l10n#851 and replaces node-gettext calls with the l10n package's new internal handling.
This makes it possible to get rid of the vulnerable node-gettext package in apps.