Skip to content

Comments

feat: export aliases t and n for translate and translatePlural#727

Merged
skjnldsv merged 1 commit intomasterfrom
feat/export-short-aliases
Feb 11, 2024
Merged

feat: export aliases t and n for translate and translatePlural#727
skjnldsv merged 1 commit intomasterfrom
feat/export-short-aliases

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 10, 2024

We do this all the time:

import { translate as t, translatePlural as n } from '@nextcloud/l10n'

This PR allows importing aliases as well in a simple way:

import { t, n } from '@nextcloud/l10n'

@ShGKme ShGKme added type: enhancement 🚀 New feature or request 3. to review 3️⃣ Waiting for reviews labels Feb 10, 2024
@ShGKme ShGKme self-assigned this Feb 10, 2024
@codecov
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1388a39) 86.17% compared to head (9a355a4) 86.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   86.17%   86.31%   +0.14%     
==========================================
  Files           6        6              
  Lines         188      190       +2     
  Branches       67       67              
==========================================
+ Hits          162      164       +2     
  Misses         23       23              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjnldsv skjnldsv merged commit e5b19d0 into master Feb 11, 2024
@skjnldsv skjnldsv deleted the feat/export-short-aliases branch February 11, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: enhancement 🚀 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants