Conversation
skjnldsv
force-pushed
the
feat/files-header
branch
from
8e621eb to
1568e62
Compare
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
feat/files-header
branch
from
1568e62 to
195ae95
Compare
juliusknorr
reviewed
Aug 4, 2023
| /** Order */ | ||
| order: number | ||
| /** Condition wether this header is shown or not */ | ||
| enabled?: (folder: Folder, view) => boolean |
Contributor
There was a problem hiding this comment.
Should the view be typed somehow?
Contributor
There was a problem hiding this comment.
I agree we should have the view types (if possible)
Contributor
Author
There was a problem hiding this comment.
Yes, we haven't migrated it from server yet! Was maing sure no changes were needed (I had to adjust quite a lot at the beginning)
juliusknorr
approved these changes
Aug 4, 2023
Contributor
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Looks good, just a small question on the view parameter typing.
susnux
approved these changes
Aug 4, 2023
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Same as Julius just the view typing
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nextcloud/server#17482
It seems no one is using the footer API in years. I think it's time to drop it 🤷