feat(sidebar): allow to postpone definition of sidebar tabs#1459
Merged
feat(sidebar): allow to postpone definition of sidebar tabs#1459
Conversation
susnux
added
type: enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
+ Coverage 86.12% 86.16% +0.03%
==========================================
Files 27 27
Lines 692 694 +2
Branches 197 198 +1
==========================================
+ Hits 596 598 +2
Misses 82 82
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
reviewed
Jan 14, 2026
Contributor
|
Does files have a spinner/placeholder during loading? |
Contributor
Author
Yes it has a loading spinner until I already use it in a hacky way: Register the web component when |
ShGKme
requested changes
Jan 15, 2026
susnux
force-pushed
the
feat/postpone-register
branch
2 times, most recently
from
fbd7a69 to
29a885e
Compare
ShGKme
approved these changes
Jan 15, 2026
Contributor
|
Unrelated: why is |
susnux
force-pushed
the
feat/postpone-register
branch
2 times, most recently
from
e12bc3b to
485f099
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Grigorii K. Shartsev <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/postpone-register
branch
from
485f099 to
6bf0138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases this might help to reduce scripts loaded on page load.