refactor(column): use interfaces rather than instances#1443
Merged
Conversation
susnux
added
3. to review
Similar to what we did with View, Node, File, and Folder. As we cannot validate class instances anyways we can just use interfaces, allowing more flexible code. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/column-interface
branch
from
4e47143 to
467618d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
=======================================
Coverage 89.64% 89.64%
=======================================
Files 26 26
Lines 705 705
Branches 189 189
=======================================
Hits 632 632
Misses 59 59
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to what we did with View, Node, File, and Folder. As we cannot validate class instances anyways we can just use interfaces, allowing more flexible code.