refactor!(navigation): pass id of view to setActive#1418
Merged
Conversation
susnux
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
==========================================
+ Coverage 90.72% 90.79% +0.06%
==========================================
Files 23 23
Lines 658 663 +5
Branches 175 177 +2
==========================================
+ Hits 597 602 +5
Misses 50 50
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
Dec 11, 2025
This ensures only registered views can be set as active. Otherwise one could set unknown views as active. Additionally this ensures that all views the navigation handles are validated in `registerView`. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/only-registered-views
branch
from
9ba1e40 to
153265e
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/only-registered-views
branch
from
153265e to
55ab07f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures only registered views can be set as active. Otherwise one could set unknown views as active.
Additionally this ensures that all views the navigation handles are validated in
registerView.(@skjnldsv I can do the changes in server for this change)