refactor: use interfaces where possible instead of instances#1417
Merged
refactor: use interfaces where possible instead of instances#1417
Conversation
This allows to use the methods in more places, especially because when wrapped in e.g. Vue the signature of private fields will be changed. Meaning that a class instance within a `ref` will not have the same type due to its private fields. But we do not need real instances here, instead just allow using the public interfaces as they contain the public API. This also allows us to have custom classes that e.g. implement the `IView` but still we ensure that it satisfies our interface. Using interfaces for API is not a breaking change, because it widenes the function interface. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
- Coverage 90.74% 90.72% -0.02%
==========================================
Files 23 23
Lines 659 658 -1
Branches 175 175
==========================================
- Hits 598 597 -1
Misses 50 50
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
Dec 11, 2025
This was referenced Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewmethods bound toViewDataobject #1068Viewto create custom classes #1067This allows to use the methods in more places, especially because when wrapped in e.g. Vue the signature of private fields will be changed. Meaning that a class instance within a
refwill not have the same type due to its private fields.But we do not need real instances here, instead just allow using the public interfaces as they contain the public API.
This also allows us to have custom classes that e.g. implement the
IViewbut still we ensure that it satisfies our interface.Using interfaces for API is not a breaking change, because it widens the function interface.