fix(node): better special character encoding and detection#1398
Merged
fix(node): better special character encoding and detection#1398
Conversation
Signed-off-by: skjnldsv <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
+ Coverage 90.64% 90.74% +0.09%
==========================================
Files 23 23
Lines 652 659 +7
Branches 175 175
==========================================
+ Hits 591 598 +7
Misses 50 50
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
nfebe
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why it fails on 4.0.0 now, discovered on nextcloud/server#56743 while working on the https://github.com/nextcloud/server/blob/d87114287b4bd3c90209dab70f7f0dc0bbb47426/apps/files/src/actions/openFolderAction.ts
Here are the failures without this fix: